Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse Iterators should 'skip to previous' when start key doesn't exist #27

Closed
rvagg opened this issue Mar 29, 2013 · 2 comments · Fixed by #30
Closed

Reverse Iterators should 'skip to previous' when start key doesn't exist #27

rvagg opened this issue Mar 29, 2013 · 2 comments · Fixed by #30

Comments

@rvagg
Copy link
Member

rvagg commented Mar 29, 2013

LevelDB only does 'skip to next' when start key doesn't exist but when you want to iterate in reverse you want your start point to be the previous closest key where your actual start doesn't exist.
We can detect and handle this situation for reverse Iterators. Edge case is end-of-database which will cause !Valid().
@kesla
Copy link
Contributor

kesla commented Mar 29, 2013

Sounds like fun. I'm interested in fixing this. Give me a day or two and you should see a PR, if that works for you.

@rvagg
Copy link
Member Author

rvagg commented Mar 29, 2013

Cool. Work from 0.2-wip. It's pretty much ready for merging to master and releasing.

kesla added a commit that referenced this issue Mar 30, 2013
@kesla
iterator: Start on correct value when reverse=true
1bb274b 
Closes #27
@kesla kesla mentioned this issue Mar 30, 2013
Merged
@kesla kesla closed this as completed in 701b3c0 Apr 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iterator: Start on correct value when reverse=true Level/leveldown
2 participants
@kesla @rvagg