-
-
Notifications
You must be signed in to change notification settings - Fork 177
Build for 32 bit platforms or only x64? #554
Comments
I'm also fine with x64 only. The GitHub API exposes download stats IIRC, we can check how many 32bit downloads we have now. |
So for the latest release, 1.9% of downloads are 32 bit. IMO it's fine to say, those few people should compile binaries themselves. |
@ralphtheninja good to close (we have an action item in #553)? |
Yep! |
Hi we're running into this issue because we are building for 32bit machines, we work with folks with old computers who live in remote locations. They have limited connectivity and will not be upgrading Windows to 64bit. Is it possible to do a prebuilt for win32? If not, is there something you could suggest for packaging leveldown>=5.0 on win32 with electron? electron-builder documentation is also quite sparse in this area, I've worked on it for a few hours now.. Here's the original issue reported from one of our partners and the error message which signals leveldown is not built for win32. digidem/mapeo-desktop#305 (comment) |
apparently building 32-bit builds of leveldown as a dependency to an electron app is challenging, https://github.com/digidem/mapeo-desktop/runs/521162496?check_suite_focus=true |
Certainly. I'd be happy to help those folks and I don't see any technical challenge on this end. The only concern is increasing our npm package size, but (surprisingly) we haven't gotten a single compliant about that yet. Is it a concern for y'all, e.g. on slow networks? |
Yeah, although now I'm trying your suggestion of running node and npm install on 32-bit and seeing if that works, even though the build machine is 64-bit |
That didn't work for me so easily and I'm going to take a break from it now. How much would it increase the package size? The app we're shipping is >80mb, so an extra 250kb won't hurt |
Adds 194kb (or 406kb unpacked) to our npm package size. Previously removed because only 2% of installs were on 32-bit Windows and we agreed those users could compile from source. However, there is currently a gap in electron(-builder) tooling when used on native addons that use node-gyp-build: these addons don't get automatically recompiled. Though we don't need that anymore for runtimes (the builds are compatible with both node and electron) our users do need it when targeting multiple CPU architectures. Ref digidem/mapeo-desktop#305 Ref electron-userland/electron-builder#4370 Ref #554
We need to modify so
prebuildify
also builds for 32 bit if this is the case. Linux and Windows.For each platform-arch we will build two binaries, so if we build for x64 only on mac, linux and windows the resulting
prebuilds/
folder will look like:How common is 32 bit? Will people cry on windows? Personally I'd go for the above setup.
The text was updated successfully, but these errors were encountered: