Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iterator seek target a local variable #682

Closed
vweevers opened this issue Oct 12, 2019 · 0 comments · Fixed by #683
Closed

Make iterator seek target a local variable #682

vweevers opened this issue Oct 12, 2019 · 0 comments · Fixed by #683
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible

Comments

@vweevers
Copy link
Member

Here:

NAPI_METHOD(iterator_seek) {

Because that's the only function in which it's used. We don't have to keep it around. Removing the need for this:

leveldown/binding.cc

Lines 559 to 567 in 55f30a3

void ReleaseTarget () {
if (target_ != NULL) {
if (!target_->empty()) {
delete [] target_->data();
}
delete target_;
target_ = NULL;
}
}

@vweevers vweevers added semver-patch Bug fixes that are backward compatible refactor Requires or pertains to refactoring labels Oct 12, 2019
vweevers added a commit that referenced this issue Oct 13, 2019
vweevers added a commit that referenced this issue Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant