-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync execution methods and performance optimization. #136
Conversation
A couple of things:
|
👍 on separate PRs. I really like the |
in fact , I just wanna the OpenSync, and GetSync are enough for me. iterator sync just as compare test :). |
But leave these choose to others, not me to choose for them. |
+ approximateSize sync if no callback
* minor bug fixed
+ nextSync, endSync on iterator * some memleak fixed
+ Iterator.nextSync, Iterator.EndSync
@ralphtheninja: already rebased. I've publish it as leveldown-sync for my requirement. also levelup-sync and memdown-sync made. |
This would have to be re-implemented since we're now based on n-api. |
[Edit: the link to the discussion in abstract-leveldon is https://github.com/Level/abstract-leveldown/pull/49 - @mcollina]