Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nyc and coveralls #497

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Add nyc and coveralls #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ leakydb
npm-debug.log
prebuilds/
yarn.lock
.nyc_output
1 change: 1 addition & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ README
INSTALL
NEWS
AUTHORS
.nyc_output/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member Author

@ralphtheninja ralphtheninja Jul 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared with level-ws and I can't figure out why irish-pub doesn't mention the .nyc_output/*.json files because they aren't in .npmignore. So for leveldown I had to add .nyc_output to .npmignore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no .npmignore then npm looks at .gitignore.

2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ node_js:
- 6
- 8
- 10

after_success: npm run coverage
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
[![AppVeyor](https://img.shields.io/appveyor/ci/Level/leveldown.svg?label=appveyor)](https://ci.appveyor.com/project/Level/leveldown)
[![dependencies](https://david-dm.org/Level/leveldown.svg)](https://david-dm.org/level/leveldown)
[![npm](https://img.shields.io/npm/dm/leveldown.svg)](https://www.npmjs.com/package/leveldown)
[![Coverage Status](https://coveralls.io/repos/github/Level/leveldown/badge.svg)](https://coveralls.io/github/Level/leveldown)
[![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)

* [Introduction](#introduction)
Expand Down
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@
},
"devDependencies": {
"async": "^2.0.1",
"coveralls": "^3.0.2",
"delayed": "~1.0.1",
"du": "~0.1.0",
"faucet": "0.0.1",
"iota-array": "~1.0.0",
"lexicographic-integer": "~1.1.0",
"mkfiletree": "~1.0.1",
"monotonic-timestamp": "~0.0.8",
"nyc": "^12.0.2",
"optimist": "~0.6.1",
"prebuild": "^7.0.0",
"prebuild-ci": "^2.0.0",
Expand All @@ -43,7 +44,8 @@
},
"scripts": {
"install": "prebuild-install || node-gyp rebuild",
"test": "standard && verify-travis-appveyor && (tape test/*-test.js | faucet) && prebuild-ci",
"test": "standard && verify-travis-appveyor && nyc tape test/*-test.js && prebuild-ci",
"coverage": "nyc report --reporter=text-lcov | coveralls",
"rebuild": "prebuild --compile",
"prebuild": "prebuild --all --strip --verbose",
"changelog": "remark CHANGELOG.md -o"
Expand Down