Refactor initialization of range options #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
semver-patch
vweevers
commented
Oct 12, 2019
| std::string* gt = RangeOption(env, options, "gt"); | ||
| std::string* gte = RangeOption(env, options, "gte"); | ||
|
|
||
| if (!reverse && gte != NULL) start = new std::string(*gte); |
There was a problem hiding this comment.
Could also do start = gte (no copy), seeing as they all have the same lifetime, but I figured it'd be a useless optimization.
|
This is probably a good time for #573 - as well as some tests on null bytes? |
ralphtheninja
approved these changes
Oct 12, 2019
Comment on lines
-720
to
+721
| leveldb::Slice* start_; | ||
| std::string* start_; |
There was a problem hiding this comment.
Nice to get rid of this special case (the delete in destructor).
vweevers
added a commit
to Level/rocksdb
that referenced
this pull request
Nov 4, 2019
Cherry-picked from Level/leveldown#681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #680.