-
-
Notifications
You must be signed in to change notification settings - Fork 267
Conversation
This looks good to me. We usually leave these open for at least 24 hours to give everyone a chance to look & comment. |
looks good to me |
Looks good to me too. |
So this'll probably get merged; but the big question is, are you happy to become a co-maintainer of levelup @pgte? See https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md Your name'll go on the maintainer list, you'll share in the copyright ownership (fwiw) and you'll get to have an equal say in discussions. |
@rvagg yes, I'd be happy to co-maintain levelup. :) |
@pgte Welcome! |
All good, published as @0.11.0, along with Julian's changes for browser compat (no-bind() and bops). Thanks! @pgte, you've been added to the repo collab list for levelup, leveldown, abstract-leveldown and level. Level is a GitHub org which you're part of now (it's more symbolic than anything at the moment). You're listed on the READMEs of each of the projects and in the package.json contributors list. You're welcome to butt in to any conversation and put in your perspective, IMO the more people with an opinion the better; sometimes it might slow things down or prevent certain features making that in but that's usually a good thing! It's mostly fairly democratic around here, I'm happy to be outvoted in discussions. I still retain sole npm package ownership but I'm doing that mainly to ensure a more consistent release schedule (but again, I'm happy to be outvoted if everyone else thinks that's not a good approach). Consider yourself a part-owner in what goes on here and make your presence felt. Best to contribute via pull requests, it's usually cleaner if you make branches on the main levelup repo and do pull requests internally. Leaving them open for discussion is usually the way to go and you don't have to wait till you're sure about something before you submit a pull request; best to get discussion going early before you invest too much in it. If you want to stay in touch, the main mechanisms we use are the issues here and ##levelup on freenode. There's also a google group that's used a little. @leveldb on twitter is also ours and generally is more node-focused than anything else. Finally, welcome on board! I'm absolutely sure your contributions will make a huge positive impact on the project(s)! |
welcome! :) |
@rvagg thanks for the intro! :) |
Welcome Pedro! :D |
Welcome! 🍻 |
welcome :D! |
Thanks, everyone! 🍻 |
Fixes #159.