Clone additionalMethods to prevent mutation (#4)

Closes #3

index.js

@@ -30,6 +30,6 @@ module.exports = function supports () {
     encodings: manifest.encodings || false,
 
     // Methods that are not part of abstract-leveldown or levelup
-    additionalMethods: manifest.additionalMethods || {}
+    additionalMethods: xtend(manifest.additionalMethods)
   })
 }

test/cloneable.js

@@ -0,0 +1,26 @@
+'use strict'
+
+var supports = require('..')
+
+// Every object in a manifest must have a unique identity, to avoid accidental
+// mutation. In supports() we only shallowly clone the manifest object itself
+// and additionalMethods. If in the future we add more objects to manifests,
+// this test will break and we'll know to start performing a deep clone.
+module.exports = function cloneable (t, manifest) {
+  var copy = supports(manifest)
+  verifyUnique(t, 'manifest', manifest, copy)
+}
+
+function verifyUnique (t, path, a, b) {
+  if (isObject(a) && isObject(b)) {
+    t.ok(a !== b, path + ' has unique identity')
+
+    Object.keys(a).forEach(function (key) {
+      verifyUnique(t, path + '.' + key, a[key], b[key])
+    })
+  }
+}
+
+function isObject (o) {
+  return typeof o === 'object' && o !== null
+}

test/index.js

@@ -2,13 +2,15 @@
 
 var xtend = require('xtend')
 var shape = require('./shape')
+var cloneable = require('./cloneable')
 
 module.exports = function suite (test, testCommon) {
   test('db has manifest', function (t) {
     var db = testCommon.factory()
     var manifest = db.supports
 
     shape(t, manifest)
+    cloneable(t, manifest)
 
     var before = xtend(manifest, {
       additionalMethods: xtend(manifest.additionalMethods)

test/self.js

@@ -3,9 +3,11 @@
 var test = require('tape')
 var supports = require('..')
 var shape = require('./shape')
+var cloneable = require('./cloneable')
 
 test('no options', function (t) {
   shape(t, supports())
+  cloneable(t, supports())
   t.end()
 })
 
@@ -44,13 +46,30 @@ test('truthy options', function (t) {
 
 test('merges input objects without mutating them', function (t) {
   var input1 = { bufferKeys: null, streams: false }
-  var input2 = { streams: true }
+  var input2 = { streams: true, additionalMethods: {} }
   var manifest = supports(input1, input2)
 
+  manifest.foobar = true
+  manifest.additionalMethods.baz = true
+
   t.same(input1, { bufferKeys: null, streams: false })
-  t.same(input2, { streams: true })
+  t.same(input2, { streams: true, additionalMethods: {} })
   t.is(manifest.bufferKeys, false)
   t.is(manifest.streams, true)
   shape(t, manifest)
   t.end()
 })
+
+test('inherits additionalMethods', function (t) {
+  var manifest = supports({ additionalMethods: { foo: true } }, {})
+  t.same(manifest.additionalMethods, { foo: true })
+  t.end()
+})
+
+test('does not merge additionalMethods', function (t) {
+  var input1 = { additionalMethods: { foo: true } }
+  var input2 = { additionalMethods: { bar: true } }
+  var manifest = supports(input1, input2)
+  t.same(manifest.additionalMethods, { bar: true })
+  t.end()
+})