Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'reach' setting (previously known as 'detection') #211

Merged
merged 16 commits into from
Nov 13, 2023
Merged

Conversation

LewisGaul
Copy link
Owner

@LewisGaul LewisGaul commented Nov 13, 2023

Implements #33

  • Update the get_nbrs() method
  • Add the UI menubar
  • Pass the new parameter through everywhere it's needed
  • Handle disabling reach in split-cell mode
  • Bump the highscores DB version and implement compat
  • Support in the bot and server (untested)
  • Get existing tests passing
  • Add tests
  • Update python version for testing with, fix black/isort formatting

@LewisGaul LewisGaul changed the base branch from main to dev November 13, 2023 00:14
@LewisGaul LewisGaul linked an issue Nov 13, 2023 that may be closed by this pull request
@LewisGaul LewisGaul marked this pull request as ready for review November 13, 2023 01:05
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (814f300) 69.50% compared to head (6e25c54) 69.82%.
Report is 1 commits behind head on dev.

Files Patch % Lines
src/minegauler/app/highscores/sqlite.py 41.17% 10 Missing ⚠️
src/minegauler/app/frontend/main_window.py 65.21% 8 Missing ⚠️
src/minegauler/app/highscores/compat/sqlite_v2.py 50.00% 7 Missing ⚠️
src/minegauler/app/core/split_cell/controller.py 50.00% 4 Missing ⚠️
src/minegauler/app/frontend/state.py 69.23% 4 Missing ⚠️
src/minegauler/app/highscores/compat/__init__.py 33.33% 2 Missing ⚠️
src/minegauler/app/shared/utils.py 87.50% 2 Missing ⚠️
src/minegauler/app/core/engine.py 83.33% 1 Missing ⚠️
src/minegauler/app/core/regular/board.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #211      +/-   ##
==========================================
+ Coverage   69.50%   69.82%   +0.32%     
==========================================
  Files          44       45       +1     
  Lines        3879     3994     +115     
==========================================
+ Hits         2696     2789      +93     
- Misses       1183     1205      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LewisGaul LewisGaul merged commit e9ed09f into dev Nov 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cell number detection option
1 participant