Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to joo_global_object #176

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Nov 19, 2024

It is deprecated. The js_of_ocaml-compiler will emit a warning when it sees joo_global_object in its next release.

@nojb nojb requested a review from mlasson December 11, 2024 11:45
@nojb
Copy link
Member

nojb commented Dec 11, 2024

Thanks for the PR (and sorry for the lag). We will review shortly.

@mlasson mlasson merged commit 9cde4d3 into LexiFi:master Dec 11, 2024
6 checks passed
@hhugo hhugo deleted the modernize branch December 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants