Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix global style BrnCardTitleConfig don't work (#310) #313

Merged

Conversation

JayceV552
Copy link
Contributor

fix global style BrnCardTitleConfig don't work (#310)


defaultConfig = BrnThemeConfigurator.instance
.getConfig(configId: defaultConfig.configId)
.cardTitleConfig
.merge(defaultConfig);
.merge(cardTitleConfig)
.merge(themeData);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要确认下,组件构造函数参数的优先级> themeData > 默认全局配置
:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, 已修正

@hexintao hexintao merged commit d547110 into LianjiaTech:3.x Sep 13, 2022
violinday added a commit that referenced this pull request Sep 30, 2022
* 3.x: (21 commits)
  Update build_test.yml (#348)
  fix: BrnIconButton 传入字体无效问题 (#346)
  add attribute emptyImage (#344)
  增加textInputAction (#337)
  fix BrnToast defaultoffset error (#343)
  fix docs (#342)
  feature: Add BrnSafeDialog (dismiss) instead of Navigator.pop to close the Dialog. (#321)
  BrnBrokenLine: xDial support selected style (#319)
  fix: BrnProgressChart 设置颜色,背景色,以及动画无效 (#326)
  feat: 增加focusNode prop,实现焦点可控 (#328)
  fix: BrnTextSelectFormItem 布局字偏上问题 (#331)
  [perf]: 优化代码:1、将 Container(),Container(width:0, height:0) 替换为 SizedBox.shrink(),2、将 InkWell 替换为 GestureDetector (#325)
  fix #333; (#335)
  Update brn_middle_input_diaolg.dart (#327)
  fix global style BrnCardTitleConfig don't work (#310) (#313)
  fix BrnMultiSelectTagsPicker style error (#316) (#320)
  Update build_test.yml (#323)
  optimize BrnPageLoading fix #295 (#298)
  Create i10n.md
  #fixbug: 修复issues275 (#301)
  ...
@lijinshanmx
Copy link
Contributor

image

BrnAppBar文字的全局配置大小调整无效,全局配置会被_defaultConfig所覆盖,问题和此种情形一样,希望能给予修复。

@lijinshanmx
Copy link
Contributor

@violinday @JunCaiLi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants