GitHub Actions NPM Release (#5)

* Remove travis

* Fix tiny syntax bug

* Add org to name in package.json

* Add templates for PRs and issues

* Add GitHub Actions for testing and publishing

* Linting not yet implemented

* Commit the package-lock file for consistent builds

.github/ISSUE_TEMPLATE/BUG_Issue.md

@@ -0,0 +1,23 @@
+---
+    name: Bug Report
+    about: Report an issue found in @unfinishedlabs/parquetjs
+    title: ""
+    labels: ""
+    assignees: ""
+---
+Thanks for reporting an issue!
+
+### Steps to reproduce
+Tell us how to reproduce this issue.
+
+### Expected behaviour
+Tell us what should happen
+
+### Actual behaviour
+Tell us what happens instead
+
+### Any logs, error output, etc?
+...
+
+### Any other comments?
+...

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,4 @@
+blank_issues_enabled: true
+contact_links:
+  - name: Issue Template
+

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,22 @@
+Problem
+=======
+problem statement
+Solution
+========
+What I/we did to solve this problem
+
+with @pairperson1
+
+Change summary:
+---------------
+* Tidy, well formulated commit message
+* Another great commit message
+* Something else I/we did
+
+Steps to Verify:
+----------------
+1. A setup step / beginning state
+1. What to do next
+1. Any other instructions
+1. Expected behavior
+1. Suggestions for testing

.github/workflows/main.yml

@@ -0,0 +1,36 @@
+name: Tests CI
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ '**' ]
+jobs:
+  test:
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Use Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: '14.16.0'
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
+      - name: Install 💾
+        run: npm ci
+
+      - name: Lint
+        run: npm run lint
+
+      - name: Test
+        run: npm run test
+
+      - name: Build & Publish Dry Run
+        run: npm publish --dry-run

.github/workflows/publish-next.yml

@@ -0,0 +1,36 @@
+name: Publish NPM @next
+on:
+  push:
+    branches: [ main ]
+jobs:
+  test:
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Use Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: '14.16.0'
+          registry-url: 'https://registry.npmjs.org'
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
+      - name: Install 💾
+        run: npm ci
+
+      - name: Version ⬆️
+        run: npm version --new-version "v0.0.0-${FULL_SHA:0:6}" --no-git-tag-version
+        env:
+          FULL_SHA: ${{ github.sha }}
+
+      - name: Publish @next 🚂
+        run: npm publish --tag next --access public
+        env:
+          NODE_AUTH_TOKEN: ${{secrets.NODE_AUTH_TOKEN}}

.github/workflows/release.yml

@@ -0,0 +1,34 @@
+name: Release Package
+on:
+  release:
+    types: [ released ]
+jobs:
+  publish-to-npm:
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Use Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: '14.16.0'
+          registry-url: 'https://registry.npmjs.org'
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
+      - name: Install 💾
+        run: npm ci
+
+      - name: Version ⬆️
+        run: npm version --new-version ${{ github.event.release.tag_name }} --no-git-tag-version
+
+      - name: Publish 🚂
+        run: npm publish --tag latest
+        env:
+          NODE_AUTH_TOKEN: ${{secrets.NODE_AUTH_TOKEN}}

.gitignore

@@ -1,7 +1,6 @@
 node_modules
 *.parquet
 npm-debug.log
-package-lock.json
 .nyc_output
 dist
 !test/test-files/*.parquet

lib/writer.js

@@ -189,7 +189,7 @@ class ParquetEnvelopeWriter {
 
   constructor(schema, writeFn, closeFn, fileOffset, opts) {
     this.schema = schema;
-    this.write = writeFn,
+    this.write = writeFn;
     this.close = closeFn;
     this.offset = fileOffset;
     this.rowCount = 0;