Fix serve and update comments

esbuild-serve.js

@@ -3,21 +3,22 @@
  * It attaches the parquet.js exports to a "parquetjs" global variable.
  * See the example server for how to use it.
  */
-const {compressionBrowserPlugin, wasmPlugin} = require("./esbuild-plugins");
+const { compressionBrowserPlugin, wasmPlugin } = require("./esbuild-plugins");
 // esbuild has TypeScript support by default. It will use .tsconfig
-require('esbuild')
-      .serve({
-        servedir: __dirname,
-      }, {
-        entryPoints: ['parquet.ts'],
-        outfile: 'main.js',
-        define: {"process.env.NODE_DEBUG": "false", "process.env.NODE_ENV": "\"production\"", global: "window" },
-        platform: 'browser',
-        plugins: [compressionBrowserPlugin,wasmPlugin],
-        sourcemap: "external",
-        bundle: true,
-        globalName: 'parquetjs',
-        inject: ['./esbuild-shims.js']
-      }).then(server => {
-          console.log("serving parquetjs", server)
-      })
+require('esbuild').context({
+  entryPoints: ['parquet.ts'],
+  outfile: 'main.js',
+  define: { "process.env.NODE_DEBUG": "false", "process.env.NODE_ENV": "\"production\"", global: "window" },
+  platform: 'browser',
+  plugins: [compressionBrowserPlugin, wasmPlugin],
+  sourcemap: "external",
+  bundle: true,
+  globalName: 'parquetjs',
+  inject: ['./esbuild-shims.js']
+}).then(context => {
+  context.serve({
+    servedir: __dirname,
+  }).then(server => {
+    console.log("serving parquetjs", server)
+  })
+})

examples/server/README.md

@@ -1,8 +1,8 @@
 # Example Server
 This is a toy server that illustrates how to use the parquetjs library built with esbuild.
-To run it: 
+To run it:
 1. npm install
-1. View and edit the files in `views` to taste   
+1. View and edit the files in `views` to taste
 1. node app.js
-1. Build and serve the parquetjs bundle in the main parquetjs directory: `npm run serve`    
+1. Build and serve the parquetjs bundle in the main parquetjs directory: `npm run serve`
 1. visit `http://localhost:3000` and click buttons, do things in the console.

lib/codec/plain.ts

@@ -205,7 +205,6 @@ function decodeValues_DOUBLE(cursor: Cursor, count: number) {
   return values;
 }
 
-// Waylands reminder to check again
 function encodeValues_BYTE_ARRAY(values: Array<Uint8Array>) {
   let buf_len = 0;
   const returnedValues: Array<Buffer> = [];