Code

Logical type : TIME#143

Code

Merged

saraswatpuneet merged 30 commits intomainLibertyDSNP/parquetjs:mainfrom logical_type_timeLibertyDSNP/parquetjs:logical_type_timeCopy head branch name to clipboardSep 13, 2024

+956-11

Commits

Commits on Sep 5, 2024

• minimal changes, passing test

  saraswatpuneet

  committed
  fb4b59a

• handle possible exceptions on conversion

  saraswatpuneet

  committed
  1ca98b8

• set the primitive type for TIME as INT64

  saraswatpuneet

  committed
  8fcafe2

Commits on Sep 6, 2024

• define field definition for time support and helper function

  saraswatpuneet

  committed
  9949fd4

• declare additional fields for TIME

  saraswatpuneet

  committed
  679c96c

• update jsonSchema to support TIME

  saraswatpuneet

  committed
  d3a1382

• add field tests for time

  saraswatpuneet

  committed
  e22fbe4

• annotate as int32 for MILLIS and int64 for rest

  saraswatpuneet

  committed
  ddfcc0e

• spec says int32 for milli, bigint for micro and nano

  saraswatpuneet

  committed
  05e2414

Commits on Sep 9, 2024

• redo based on generated types

  saraswatpuneet

  committed
  38a1d57

• add TIME related primitive converters

  saraswatpuneet

  committed
  dddb09a

• support time field for json schema

  saraswatpuneet

  committed
  9401f67

• finalize implementation side of TIME logical type

  saraswatpuneet

  committed
  13007a5

• set converted types for backward compatibility

  saraswatpuneet

  committed
  ae58c96

• set example field tests

  saraswatpuneet

  committed
  42d72ad

Commits on Sep 10, 2024

• set an example time schema

  saraswatpuneet

  committed
  510f402

• set schema test

  saraswatpuneet

  committed
  bc9e11c

• update schema files for testing

  saraswatpuneet

  committed
  44f64aa

• schema test result file

  saraswatpuneet

  committed
  97b1475

Commits on Sep 11, 2024

• adjust types based on ongoing file tests

  saraswatpuneet

  committed
  6485753

• logical types from parquet file cannot be reconstructed back without schema

  saraswatpuneet

  committed
  6927f31

• Merge branch 'main' into logical_type_time

  saraswatpuneet

  authored
  bd1cb5d

• remove debug logs

  saraswatpuneet

  committed
  abf7f0b

Commits on Sep 12, 2024

• add schema test for millis, macros and nanos

  saraswatpuneet

  committed
  0a5040f

• update existing test to include logicalType

  saraswatpuneet

  committed
  119bc70

• revert and fix decodeSchema.js test inline with recent changes

  saraswatpuneet

  committed
  6958dab

• pick default or 0 whichever

  saraswatpuneet

  committed
  6ec10b8

• pick default unit for now,

  saraswatpuneet

  committed
  96ec9f7

• fix typo

  saraswatpuneet

  committed
  06b7441

• better schema

  saraswatpuneet

  committed
  8ca323a