Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug caused by side-effect of change in bloomFilterReader. regen package-lock #19

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

shannonwells
Copy link
Collaborator

@shannonwells shannonwells commented Jul 1, 2021

Problem

Broken build.

The change to bloomFilterReader in PR #17 undid a side-effect: because it imported ParquetEnvelopeReader from "parquet", tsc was dutifully copying the parquet.js file to the dist folder. After it was imported via relative path ("../reader"), the side-effect went away and parquet.js was no longer copied and so no longer published with the package, which breaks it.

Solution

Add parquet.js explicitly to the "include" list in tsconfig.
Also regenerated package-lock.json to bump some patch versions.

To Verify

  1. Check out the sdk
  2. Check out this branch
  3. alter .tool-versions to use the same as what is in the sdk
  4. run npm i && npm link
  5. go to the sdk repo and run npm link @dsnp/parquetjs
  6. All tests should pass, but specifically, all tests insrc/core/batch should pass.

@shannonwells shannonwells changed the title fix bug caused by side-effect of change in xxhasher. regen package-lock fix bug caused by side-effect of change in bloomFilterReader. regen package-lock Jul 1, 2021
@shannonwells shannonwells merged commit f605856 into main Jul 1, 2021
@shannonwells shannonwells deleted the bugs/fix-build branch July 1, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants