fix bug caused by side-effect of change in bloomFilterReader. regen package-lock #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Broken build.
The change to bloomFilterReader in PR #17 undid a side-effect: because it imported
ParquetEnvelopeReader
from"parquet"
, tsc was dutifully copying the parquet.js file to the dist folder. After it was imported via relative path ("../reader"
), the side-effect went away and parquet.js was no longer copied and so no longer published with the package, which breaks it.Solution
Add parquet.js explicitly to the "include" list in tsconfig.
Also regenerated package-lock.json to bump some patch versions.
To Verify
npm i && npm link
npm link @dsnp/parquetjs
src/core/batch
should pass.