Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to variables in script #259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Apr 3, 2024

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closes #258

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Make script and text consistent in using quotes and in having the same documentation

- Use consistent syntax
- Make it easier to read the example without scrolling
Copy link

github-actions bot commented Apr 3, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-shell/compare/md-outputs..md-outputs-PR-259

The following changes were observed in the rendered markdown documents:

 04-loops.md                   |  9 +++++----
 files/my_first_bash_script.sh | 12 +++++++-----
 md5sum.txt                    |  2 +-
 3 files changed, 13 insertions(+), 10 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-03 12:05:42 +0000

github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
@@ -1,8 +1,10 @@
#!/bin/bash
# This script loops through .txt files, returns the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue with formatting of this comment - doesn't match what is in the lesson

@kaitlinnewson
Copy link
Member

Hi @bkmgit, thank you for this PR! I've made one small change request above - can you adjust this in your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script in loops section is inconsistent with rest of the text
2 participants