Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MATERIAL class #954

Open
michal-josef-spacek opened this issue Mar 10, 2024 · 5 comments
Open

Fix MATERIAL class #954

michal-josef-spacek opened this issue Mar 10, 2024 · 5 comments
Assignees
@rurban
Labels
bug Something isn't working

Comments

@michal-josef-spacek
Copy link
Contributor

When I compile libredwg without --enable-debug (tested on mingw cross compilation). The conversion of DWG with MATERIAL class to JSON and back is not working. Output DWG file is not possible to open in AutoCAD.

This is partially related to the implementation of MATERIAL class.
This was referenced Mar 10, 2024
Closed
Closed
@rurban
Copy link
Contributor

rurban commented Mar 10, 2024

MATERIAL.gentexture and several other MATERIAL features are not yet supported. These should be disabled without DEBUG

@michal-josef-spacek
Copy link
Contributor Author

If I understand correctly, we need to stable MATERIAL class and after this, we could remove hacks for roundtripping for MATERIAL (https://github.com/LibreDWG/libredwg/blob/master/src/encode.c#L3277). Am I right?

@rurban
Copy link
Contributor

rurban commented Mar 10, 2024

We won't get procedural Materials stable anytime soon, but the rest would be great. So encode should warn and disable it. Just enable it with enable-debug

@rurban
Copy link
Contributor

rurban commented Jul 6, 2024

renaming IMAGE,WIPEOUT.size to image_size fixed the debug json roundtrip

rurban added a commit that referenced this issue Jul 6, 2024
@rurban
api: rename IMAGE.size to image_size
6a4a737 
because of json clashes.
Helps also GH #954
@rurban rurban self-assigned this Jul 6, 2024
@rurban rurban added the bug Something isn't working label Jul 6, 2024
@rurban
Copy link
Contributor

rurban commented Jul 6, 2024

I've re-enabled MATERIAL (and WIPEOUT) in the branch smoke/material. No oda errors with r2000 json roundtrips anymore. But still oda errors with r2004-2018

rurban added a commit that referenced this issue Jul 6, 2024
@rurban
encode: re-enable MATERIAL
435f11c 
GH #954
rurban added a commit that referenced this issue Jul 7, 2024
@rurban
encode: re-enable MATERIAL
4b4f474 
GH #954
rurban added a commit that referenced this issue Jul 7, 2024
@rurban
encode: re-enable MATERIAL
8dba69a 
GH #954
rurban added a commit that referenced this issue Jul 7, 2024
@rurban
encode: re-enable MATERIAL
01b1cc6 
GH #954
rurban added a commit that referenced this issue Jul 8, 2024
@rurban
encode: re-enable MATERIAL
9ba351d 
GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
55ba15d 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
52a4719 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
bab87d3 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
2d25035 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
f638ac6 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
c918f9b 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
77b5039 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
9a44717 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
19a8cea 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
379b8f0 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
c6ddf7e 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
81e0a8d 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
1f71cd6 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
de74d17 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
f2862e5 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
689a15e 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
7b4b6cd 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
74464ae 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
bacc93e 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
d8e3c51 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
c08751a 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
638f963 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
185dcc9 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
encode: re-enable MATERIAL
c53b852 
GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
d5f7af1 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
738828e 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
9bea750 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
b039f5d 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
5377ea8 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
3e36a2b 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
bb1809b 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
0007881 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 13, 2024
@rurban
api: rename IMAGE.size to image_size
cc3aca6 
because of json clashes.
Helps also GH #954
rurban added a commit that referenced this issue Jul 27, 2024
@rurban
encode: more disable_3DSOLID_materials
5ab3925 
disable materials in 3DSOLIDs and all its subtypes.
GH #954
rurban added a commit that referenced this issue Jul 27, 2024
@rurban
encode: more disable_3DSOLID_materials
5c3802b 
disable materials in 3DSOLIDs and all its subtypes.
GH #954
rurban added a commit that referenced this issue Jul 27, 2024
@rurban
encode: more disable_3DSOLID_materials
5cfc387 
disable materials in 3DSOLIDs and all its subtypes.
GH #954
rurban added a commit that referenced this issue Jul 27, 2024
@rurban
encode: more disable_3DSOLID_materials
11e50f5 
disable materials in 3DSOLIDs and all its subtypes.
GH #954
rurban added a commit that referenced this issue Jul 28, 2024
@rurban
encode: re-enable MATERIAL
294f022 
GH #954
rurban added a commit that referenced this issue Aug 1, 2024
@rurban
encode: re-enable MATERIAL
c6d03d8 
GH #954
rurban added a commit that referenced this issue Aug 16, 2024
@rurban
encode: re-enable MATERIAL
085a7d1 
GH #954
rurban added a commit that referenced this issue Aug 16, 2024
@rurban
encode: re-enable MATERIAL
378377a 
GH #954
rurban added a commit that referenced this issue Aug 16, 2024
@rurban
encode: re-enable MATERIAL
1c3368c 
GH #954
rurban added a commit that referenced this issue Aug 18, 2024
@rurban
encode: re-enable MATERIAL
dd6464b 
GH #954
rurban added a commit that referenced this issue Sep 17, 2024
@rurban
encode: re-enable MATERIAL
105028b 
GH #954
rurban added a commit that referenced this issue Sep 20, 2024
@rurban
encode: re-enable MATERIAL
f2eb40a 
GH #954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rurban rurban

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rurban @michal-josef-spacek