Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building with MOLD linker #6665

Closed
wants to merge 5 commits into from
Closed

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented Jul 1, 2022

This adds support for using the mold linker, similar to how we support the GOLD linker.

This isn't enabled by default so shouldn't be much concern. You cannot have both GOLD_SUPPORT and MOLD_SUPPORT enabled at the same time though there isn't anything stopping you from doing so.

ref: https://github.com/rui314/mold

There is a few packages that don't compile with MOLD and I plan on submitting bug reports for those.

@vpeter4
Copy link
Contributor

vpeter4 commented Jul 1, 2022

Why using extra mold patch file if adding flags to make command line works the same (as indicated in comment above in Makefile).
make ${PKG_MAKE_OPTS_HOST} CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}"

@lrusak
Copy link
Member Author

lrusak commented Jul 4, 2022

Why using extra mold patch file if adding flags to make command line works the same (as indicated in comment above in Makefile).

make ${PKG_MAKE_OPTS_HOST} CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}"

Good catch, thanks. I went through a couple iterations and cleaned the package up a bit.

@lrusak
Copy link
Member Author

lrusak commented Jul 11, 2022

Merge?

Copy link
Member

@CvH CvH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

config/optimize Outdated Show resolved Hide resolved
packages/devel/mimalloc/package.mk Outdated Show resolved Hide resolved
packages/devel/mold/package.mk Outdated Show resolved Hide resolved
packages/devel/tbb/package.mk Outdated Show resolved Hide resolved
@SupervisedThinking
Copy link
Contributor

SupervisedThinking commented Jul 14, 2022

IMHO the package template is pretty much straight forward if it comes to this topic:

# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)

https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/packages.mk.template#L2

@SupervisedThinking
Copy link
Contributor

Well well well - what's the deal with this PR now? Couldn't we just bring the copyright header in line with the current standards, get this merged & figure a proper way out afterwards? Or should this pretty useful improvement rotten?

@lrusak
Copy link
Member Author

lrusak commented Sep 10, 2022

merge?

@@ -0,0 +1,22 @@
# SPDX-License-Identifier: GPL-2.0-only
# Copyright (C) 2022=present Team LibreELEC (https://libreelec.tv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be -

@CvH
Copy link
Member

CvH commented Sep 11, 2022

afaik this PR has several shortcomings (not working for ARM) that are fixed at #6875

No idea if we want to merge this and #6875 as "patch" ontop or just supersede this pr with #6875.

@CvH
Copy link
Member

CvH commented Oct 12, 2022

superseded by #6875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants