-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building with MOLD linker #6665
Conversation
Why using extra mold patch file if adding flags to make command line works the same (as indicated in comment above in Makefile). |
Good catch, thanks. I went through a couple iterations and cleaned the package up a bit. |
Merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good
IMHO the package template is pretty much straight forward if it comes to this topic:
https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/packages.mk.template#L2 |
Well well well - what's the deal with this PR now? Couldn't we just bring the copyright header in line with the current standards, get this merged & figure a proper way out afterwards? Or should this pretty useful improvement rotten? |
merge? |
@@ -0,0 +1,22 @@ | |||
# SPDX-License-Identifier: GPL-2.0-only | |||
# Copyright (C) 2022=present Team LibreELEC (https://libreelec.tv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be -
superseded by #6875 |
This adds support for using the mold linker, similar to how we support the GOLD linker.
This isn't enabled by default so shouldn't be much concern. You cannot have both
GOLD_SUPPORT
andMOLD_SUPPORT
enabled at the same time though there isn't anything stopping you from doing so.ref: https://github.com/rui314/mold
There is a few packages that don't compile with MOLD and I plan on submitting bug reports for those.