Encoding for cross reference table wrong

[soenkekueper]

When creating an pdf on an system with different default encoding (for example ibm z/os where IBM-273 is the default encoding) the cross reference table is written in that encoding and afterwards unreadable.

Description of the new Feature/Bugfix

When writing the cross reference table entries now the Method PdfEncodings.convertToBytes without encoding is used, so the values are written as ISO-8859-1 bytes instead of IBM-273 encoded values.

Related Issue: #

Unit-Tests for the new Feature/Bugfix

jUnit Test SimplePdfTest.testCrossReferenceTableEncoding() added

Compatibilities Issues

No.

Testing details

I'll build this locally and include in our deployment and run on our z/os mainframe.

[soenkekueper]

Sorry this is a duplicate of #614. I've been too fast with correction and didn't check for other PRs in advance.
May be closed if #614 got merged.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[asturio]

Hi @soenkekueper , the test is not green. Can you take a look at it?

[soenkekueper]

Hey,
this is, unfortunately, not a bug within the test, but a runtime problem with the java module system.
So this test only fails with java 16, but not with java 11.

The cause is that i've to reset the privafte field Charset.defaultCharset, for java property file.encoding to be evaluated.
So i'm using reflection to do so. But with the module system, this access is not allowed, which leads to an InaccessibleObjectException.

The change of file.encoding must be done, because if this is not changed, the test would also pass with the old implementation (on all systems that usw an ISO based enoding, which is the case).

So i see the following options for now:

1. add the java parameter --add-opens java.base/java.nio.charset=ALL-UNNAMED for test execution
2. do not execute the test case for java 16
3. remove the entire test

What would you suggest as best solution?

[asturio]

I'll checkout your branch and try to make the test pass.