Issue676: references in tag structure tree are incorrect #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @AnthonyStevens . The checkstyle problems were fixed on master. Can you please rebase your branch onto OpenPdf/master? |
dadza
added a commit
to Jaspersoft/OpenPDF
that referenced
this pull request
Jan 30, 2023
alternative fix at LibrePDF#765
2 tasks
|
Fixed with #903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
The code to create indirect references in the tag structure tree was modifying a copy of the arrays rather than the arrays themselves.
Related Issue: #676
Unit-Tests for the new Feature/Bugfix
None
Compatibilities Issues
None
Testing details
The Acrobat syntax checker no longer reports an error