Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle photos with multiple files better #719

Open
6 of 9 tasks
derneuere opened this issue Jan 4, 2023 · 0 comments
Open
6 of 9 tasks

Handle photos with multiple files better #719

derneuere opened this issue Jan 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@derneuere
Copy link
Member

derneuere commented Jan 4, 2023

Describe the enhancement you'd like
Right now, we just save all different files for a photo in a string. However, this limits a lot of options. We do not what type of files these are and what the hash is etc. This makes it impossible to handle things like live photos, raw photos with thumbnails, movies with thumbnails, stacking similar images or create version that were edited in a future photo editor.

Steps to do:

  • Create a file model
  • Add a files field to photo
  • Add a main file field to photo
  • Migrate current image_paths to files
  • Fix about a million lines that used image_paths
  • Make sure that every action still works
  • Migrate image_hash to file
  • Use UUID or ULID as a primary key for photo model instead
  • Add a semantic_image_hash field

Describe why this will benefit the LibrePhotos
This is needed to implement multiple open issues like #287 #481

@derneuere derneuere added the enhancement New feature or request label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant