Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iOS Live Photos #287

Open
meichthys opened this issue Jun 26, 2021 · 8 comments
Open

Support for iOS Live Photos #287

meichthys opened this issue Jun 26, 2021 · 8 comments

Comments

@meichthys
Copy link
Contributor

Support for iOS Live Photos would be a welcome feature for any iOS user. I've come to love (and rely on) the live 'mini video' feature that has been added to iOS photos.

Adding this feature would make the transition from Apple Photos much more seamless.

@meichthys meichthys added the enhancement New feature or request label Jun 26, 2021
@MatthewBraun
Copy link

THIS PLEASE!
Using Exiftool the photo (.heic) contains
Media Group UUID : C3F5C9D7-*****

And the video (.mov) contains
Live Photo Auto : 1
Content Identifier : C3F5C9D7-*****
Live Photo Vitality Score : 0.939849615097046
Live Photo Vitality Scoring Version: 4

This could be used to link the two files together.
A non LivePhoto doesn't contain the "Media Group UUID" attribute.

@spiek90
Copy link

spiek90 commented Feb 27, 2022

Live photos would be a great feature indeed. If you need some examples, I'm happy to send some over.

@meichthys
Copy link
Contributor Author

@derneuere Do you have an idea how involved this might be? Would it be a good first-issue or something that someone unfamiliar with the code may be able to implement?

Without Live Photos support, Librephotos is very cluttered since every photo has a duplicate video.

@derneuere
Copy link
Member

This contains the following two problems:

  1. The photo and video should not be duplicated and should be saved in the same photo
  • Add a function that allows for the detection of live photos and add that here: https://github.com/LibrePhotos/librephotos/blob/dev/api/directory_watcher.py
    • Handle missing photo or video of a live photo correctly. Is it in the beginning a photo/video and displayed, or do we hide incomplete live photos?
    • Do we need a new field media group in order to query the database, and what about colliding media groups? Should we assume that live photos are always in the same folder in order to fix that?
    • What about different implementations of live photos from samsung phones, for example?
    • Test rescanning and implementing cases that follow from that
    • The result should be adding the path of the video and image to the same "photo" and setting the correct type.
  1. Display live photos in the correct way
  • Change the photo model to have a "type", which can be "photo", "video" or "live photo" and remove the video attribute
    • Use the migration from django in order to do that
  • Calculate the thumbnails correctly. It has videos thumbnails for small and medium thumbnails for react-pig, but it's a picture when viewed in the lightbox.
    • Is this correct, or are live photos displayed differently?
  • Change the serializer method used for types and change it everywhere where video is used
  • Change the lightbox to handle the new type
  • Change react-pig to handle the new type. Do we need an overlay to indicate that it is a live photo?
  • Change the mobile app to handle the new type

It will take some time, but if somebody wants to implement it, it can be done :)

@meichthys
Copy link
Contributor Author

Wow, thanks for the thorough reply 👍
I think it's beyond my abilities and available time at the moment, but I'll be sure to follow the sub and offer help/input where needed when we start to make progress on this.

@wjbeckett
Copy link

  • Change react-pig to handle the new type. Do we need an overlay to indicate that it is a live photo?

Absolutely need an overlay to indicate it's a live photo.
Something like this in the top right corner would be nice.

live-photos-50

@meichthys
Copy link
Contributor Author

Just for reference: The live icon in iOS Photos is on the top left.

@WhiteHatRootkitJedi
Copy link

Hi all, is anyone working on this feature?

AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
…lugin-react-7.x

Update dependency eslint-plugin-react to v7.33.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants