fix: check if is alpine #3049
Merged
fix: check if is alpine #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to download specific Java package to Alpine. ref: #3026 Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
…ersion> not <ID> therefore the field have to be $matches['version'] to make a correct check
|
The additional checks you implemented to determine alpine work, but when you check on the result you use the Identifier ID instead of "version" which would be the correct one (named group in the regex) I made a pull request here: #3053 to address that issue. With your two commits and the bugfix in the pull request it works now well to install compatible java with LibreSign in Nextcloud AIO / Alpine based Nextcloud |
Wrong identifier on new distribution check (Successfully tested on Nextcloud-AIO)
|
/backport to stable29 |
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to download specific Java package to Alpine.
Reference: