Refactor API to use an interface. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interfaces allow mocking libraries to mock our types more easily. This will prevent users of KVault from having to wrap KVault with another type when they want to test code which uses it.
|
@jadar sry due to other PRs this one is no conflicting. Do you mind resolving the conflicts? Overall your implementation looks promising, breaking changes cannot be avoided which is fine IMHO. |
|
@benjohnde I merged the upstream |
|
@canonall @ductavius @tknoelle we don't need to use a new published version with breaking api changes soon, but before merge I wanted to get a short confirm from you guys as well! |
|
Thanks a million @jadar ! |
|
The changes are fine for me @benjohnde. Thanks a lot @jadar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfaces allow mocking libraries to mock our types more easily. This will prevent users of KVault from having to wrap KVault with another type when they want to test code which uses it.
This will be a breaking API change, unfortunately, because any users which extend the
KVaultclass will have to extendKVaultImplinstead.This follows the Kotlin coding convention pattern, here
Closes #42