Refactor Plugin Extension to avoid duplicate attributes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 26, 2023 11:25
to remove all the duplicate in plugin extension configuration, i replaced the builder objects with normal extension attributes that we can reuse in all tasks.
to remove all the duplicate in plugin extension configuration, i replaced the builder objects with normal extension attributes that we can reuse in all tasks.
…ibutes to remove all the duplicate in plugin extension configuration, i replaced the builder objects with normal extension attributes that we can reuse in all tasks.
to remove all the duplicate in plugin extension configuration, i replaced the builder objects with normal extension attributes that we can reuse in all tasks.
to remove all the duplicate in plugin extension configuration, i replaced the builder objects with normal extension attributes that we can reuse in all tasks.
Ingwersaft
reviewed
Jul 26, 2023
src/main/kotlin/com/liftric/dtcp/tasks/GetOutdatedDependenciesTask.kt
Outdated
Show resolved
Hide resolved
Ingwersaft
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin extension was adjusted and all unnecessary builders removed to avoid attribute duplicates.
Added projectUUID to all Tasks, so we are more consistence.
Fix a Bug in Risk Score, where we might get a Null Pointer Exception if the API Response has a null Value on the lastInheritedRiskScore.
Added GradleException's if the user doesn't not specify uuid or name/version.
Adjusted Integration Tests with new Plugin Extension.
Adjusted Readme with the new correct Plugin Configuration