wip: Init Code for Plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 5, 2023 14:35
renamed updateRepo to uploadDebian -> added name and version parameter to override version and packagename from debian file and for future clean task specification
added origin + label input param for Release File added CleanPackages Step > added component and suite input param for that (has default stable/main value) removed unused parameter from tasks fixed Date Field -> CEST Date gives apt error fixed poolbucketkey function: >the key must have component and not suite added deleteObjects function to s3Client
This commit refactors the code to include additional APT repository metadata configuration options. The following changes were made: In S3AptRepositoryPlugin.kt, the properties origin, label, suite, and component were added to the PluginExtension class and set to the corresponding values from the extension. In RemovePackageTask.kt and UploadPackageTask.kt, the properties origin, label, suite, and component were added as inputs and assigned values based on the extension or the default values if not provided. These additions allow users to customize the APT repository origin, label, suite, and component. The values can be set at the top level for the entire repository or overridden individually for specific Debian files or packages. The new properties are optional, allowing flexibility in the repository configuration. Note: The origin, label, suite, and component properties have been introduced to provide enhanced customization options for the APT repository. Refer to the updated documentation for more details on how to use these properties effectively.
Ingwersaft
reviewed
Jun 13, 2023
Ingwersaft
reviewed
Jun 13, 2023
added 19 commits
June 13, 2023 16:20
add more unit tests + mock tests refactored a little of the main code for easier testing
renamed some input parameters and classes for better naming
refactored releaseinfo to stop being mutable
added 3 commits
June 15, 2023 17:29
in the next step i add release file field attributes and one of them are architecture. for this i have to rename the architecture attribute from the package to packageArchitecture. This is also good, because all other package Attributes starting with package... (packageName, packageVersion)
added release file attributes - added test for this added comments rename some stuff
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 Tasks:
Added Unit Tests with Mockk for S3
Added Integration Tests
Added Readme
Added Workflow for Testing
Added Workflow for Plugin Publish
TODO: