ref: move lr_finder (#3434)

* ref: move lr_finder * ref: move lr_finder * ref: move lr_finder * ref: move lr_finder * ref: move lr_finder * ref: move lr_finder * ref: move lr_finder
Lightning-AI · Sep 10, 2020 · 5abf7d9 · 5abf7d9
1 parent 435e479
commit 5abf7d9
Show file tree

Hide file tree

Showing 5 changed files with 263 additions and 198 deletions.
diff --git a/docs/source/lr_finder.rst b/docs/source/lr_finder.rst
@@ -83,7 +83,7 @@ of this would look like
     trainer = Trainer()
     
     # Run learning rate finder
-    lr_finder = trainer.lr_find(model)
+    lr_finder = trainer.tuner.lr_find(model)
     
     # Results can be found in
     lr_finder.results
@@ -110,7 +110,5 @@ This is the point returned py ``lr_finder.suggestion()``.
 
 The parameters of the algorithm can be seen below.
 
-.. autoclass:: pytorch_lightning.trainer.lr_finder.TrainerLRFinderMixin
-   :members: lr_find
+.. autofunction:: pytorch_lightning.tuner.lr_finder.lr_find
    :noindex:
-   :exclude-members: _run_lr_finder_internally, save_checkpoint, restore
diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py
@@ -35,7 +35,6 @@
 from pytorch_lightning.trainer.distrib_data_parallel import TrainerDDPMixin
 from pytorch_lightning.utilities import device_parser
 from pytorch_lightning.trainer.logging import TrainerLoggingMixin
-from pytorch_lightning.trainer.lr_finder import TrainerLRFinderMixin
 from pytorch_lightning.trainer.model_hooks import TrainerModelHooksMixin
 from pytorch_lightning.trainer.optimizers import TrainerOptimizersMixin
 from pytorch_lightning.trainer.states import TrainerState, trainer_state
@@ -97,7 +96,6 @@ class Trainer(
     TrainerTrainingTricksMixin,
     TrainerDataLoadingMixin,
     TrainerCallbackConfigMixin,
-    TrainerLRFinderMixin,
     TrainerDeprecatedAPITillVer0_10,
 ):
     def __init__(
@@ -454,7 +452,7 @@ def tune(
 
         # Run learning rate finder:
         if self.auto_lr_find:
-            self._run_lr_finder_internally(model)
+            self.tuner.internal_find_lr(self, model)
             model.logger = self.logger  # reset logger binding
 
     # -----------------------------