Skip to content

Commit

Permalink
exclude mpi run from auto-detection of horovod (#8610)
Browse files Browse the repository at this point in the history
  • Loading branch information
awaelchli committed Jul 30, 2021
1 parent c99e2fe commit b6ea637
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).



-
- Fixed horovod auto-detection when horovod is not installed and the launcher is `mpirun` ([#8610](https://github.com/PyTorchLightning/pytorch-lightning/pull/8610))

### Fixed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ def check_horovod(self):
@staticmethod
def has_horovodrun() -> bool:
"""Returns True if running with `horovodrun` using Gloo or OpenMPI."""
return "OMPI_COMM_WORLD_RANK" in os.environ or "HOROVOD_RANK" in os.environ
return _HOROVOD_AVAILABLE and ("OMPI_COMM_WORLD_RANK" in os.environ or "HOROVOD_RANK" in os.environ)

def update_device_type_if_ipu_plugin(self) -> None:
# This allows the poptorch.Options that are passed into the IPUPlugin to be the source of truth,
Expand Down

0 comments on commit b6ea637

Please sign in to comment.