Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoringModel notebook import outdated #10490

Closed
jiwidi opened this issue Nov 11, 2021 · 2 comments · Fixed by #10521
Closed

BoringModel notebook import outdated #10490

jiwidi opened this issue Nov 11, 2021 · 2 comments · Fixed by #10521
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on
Milestone

Comments

@jiwidi
Copy link
Contributor

jiwidi commented Nov 11, 2021

🐛 Bug

The model notebook at GColab you link when creating an issue is outdated. Tries to import metrics from pytorch lightning:

from pytorch_lightning.metrics.functional import accuracy

I believe this is because pytorch_lightning doesn't include torchmetrics anymore, and they are a completely separate library.

To Reproduce

Go to the link and try to run it:
https://colab.research.google.com/drive/1HvWVVTK8j2Nj52qU4Q4YCyzOm0_aLQF3?usp=sharing

Expected behavior

To run smoothly!

How to solve it

Replace the import with a torchmetrics import:

from torchmetrics.functional import accuracy

I would open a PR myself but I couldnt find the notebook on the repo. It could be beneficial maybe to include it as part of the pl_examples? Then link the colab notebook to the version on master branch. That I could open a PR :)

Environment

Latest google colab

@jiwidi jiwidi added bug Something isn't working help wanted Open to be worked on labels Nov 11, 2021
@jiwidi jiwidi changed the title The BoringModel notebook is outdated BoringModel notebook import outdated Nov 11, 2021
@rohitgr7
Copy link
Contributor

I think we should keep a bug_report notebook inside pl_examples and link that one instead so that it can be updated whenever it's required to be.

https://colab.research.google.com/github/PyTorchLightning/pytorch-lightning/blob/master/pl_examples/bug_report_model.ipynb

@carmocca
Copy link
Contributor

Yes, let's do that, we only need to update the issue template and add this ipynb

@carmocca carmocca added the good first issue Good for newcomers label Nov 12, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants