Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added boring model as a ipynb so it can be updated #10521

Merged
merged 8 commits into from
Nov 19, 2021

Conversation

jiwidi
Copy link
Contributor

@jiwidi jiwidi commented Nov 13, 2021

What does this PR do?

Fixes #10490

This PR adds the boring model notebook along with a needed fix on an outdated import. The purpose of this PR is so the google colab linking to the boring model aims at the ipynb version on master, allowing the PL team to update and mantain the notebook within github.

If this PR moves forward, the default issue link should be updated.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [Is it necessary? Could do it needed] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@akihironitta akihironitta added bug Something isn't working example labels Nov 14, 2021
@akihironitta akihironitta added this to the 1.5.x milestone Nov 14, 2021
@carmocca carmocca self-assigned this Nov 14, 2021
@carmocca carmocca modified the milestones: 1.5.x, 1.6 Nov 14, 2021
@rohitgr7
Copy link
Contributor

  1. Shall we remove the torchmetrics from the bug report model? The reason to remove torchmetrics is we don't want user to explicitly install it always since its a completely separate package and also accuracy imported isn't used anywhere.
  2. Shall we remove bolts requirements? Whatever's imported from bolts isn't used either.
  3. Keep both notebook and script under pl_examples/bug_report/<.py and .ipynb>??

@tchaton
Copy link
Contributor

tchaton commented Nov 15, 2021

  • Shall we remove the torchmetrics from the bug report model? The reason to remove torchmetrics is we don't want user to explicitly install it always since its a completely separate package and also accuracy imported isn't used anywhere.
  • Shall we remove bolts requirements? Whatever's imported from bolts isn't used either.
  • Keep both notebook and script under pl_examples/bug_report/<.py and .ipynb>??

We should also drop torch vision, Mnist import. Let's keep it minimal.

@jiwidi
Copy link
Contributor Author

jiwidi commented Nov 16, 2021

I'll change the imports again and add the colab link to the github issue template then!

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Much cleaner !

@carmocca carmocca enabled auto-merge (squash) November 19, 2021 14:44
@carmocca carmocca merged commit 721b841 into Lightning-AI:master Nov 19, 2021
rohitgr7 pushed a commit that referenced this pull request Nov 22, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@carmocca carmocca modified the milestones: 1.6, 1.5.x Nov 24, 2021
lexierule pushed a commit that referenced this pull request Nov 24, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoringModel notebook import outdated
6 participants