Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing examples #4694

Closed
Borda opened this issue Nov 16, 2020 · 3 comments · Fixed by #4995
Closed

fix failing examples #4694

Borda opened this issue Nov 16, 2020 · 3 comments · Fixed by #4995
Assignees
@awaelchli @Borda
Labels
bug Something isn't working ci Continuous Integration example help wanted Open to be worked on priority: 1 Medium priority task strategy: dp (removed in pl) DataParallel
Milestone
pl:1.2

Comments

@Borda
Copy link
Member

Borda commented Nov 16, 2020

🐛 Bug

We have uncommented PL examples in #4551 but two of them turned to be failing and shall be fixed:

FAILED pl_examples/test_examples.py::test_examples_dp_image_classifier[\n--max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2 --gpus 2 --distributed_backend dp --precision 16 ]
FAILED pl_examples/test_examples.py::test_examples_dp_autoencoder[\n--max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2 --gpus 2 --distributed_backend dp --precision 16 ]

To Reproduce

uncomment two remaining examples with TODO comment

Environment

Drone Multi-GPU testing

Additional context

get back full example testing...
@Borda Borda added bug Something isn't working help wanted Open to be worked on example ci Continuous Integration labels Nov 16, 2020
@Borda Borda added the priority: 0 High priority task label Nov 17, 2020
@Borda Borda added this to the 1.1 milestone Nov 17, 2020
@Borda Borda mentioned this issue Nov 17, 2020
Closed
@Borda Borda self-assigned this Nov 17, 2020
@edenlightning edenlightning modified the milestones: 1.1, 1.0.x Nov 17, 2020
@Borda Borda modified the milestones: 1.0.x, 1.1 Nov 18, 2020
@Borda Borda mentioned this issue Nov 18, 2020
Merged
11 tasks
This was referenced Nov 18, 2020
Merged
Merged
@Borda Borda mentioned this issue Dec 7, 2020
Merged
11 tasks
@Borda Borda modified the milestones: 1.1, 1.1.x Dec 10, 2020
@edenlightning
Copy link
Contributor

TODO: add doctest so we can verify that the API is up tp date

@Borda
Copy link
Member Author

Borda commented Dec 11, 2020

TODO: add doctest so we can verify that the API is up tp date

adding doctests in #5079 #5083 #5085

@jspaezp jspaezp mentioned this issue Dec 17, 2020
Closed
@Borda Borda added priority: 1 Medium priority task and removed priority: 0 High priority task labels Jan 7, 2021
@Borda
Copy link
Member Author

Borda commented Jan 7, 2021

Atm considering adding ddp examples only for master as they take quite some time to run, see #4995 (which shall be the last one from fixing sequence)

@Borda Borda modified the milestones: 1.1.x, 1.2 Feb 8, 2021
@edenlightning edenlightning removed this from the 1.2 milestone Feb 8, 2021
@edenlightning edenlightning added this to the 1.2.x milestone Feb 8, 2021
@Borda Borda modified the milestones: 1.2.x, 1.2 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awaelchli awaelchli

@Borda Borda

Labels
bug Something isn't working ci Continuous Integration example help wanted Open to be worked on priority: 1 Medium priority task strategy: dp (removed in pl) DataParallel
Projects
None yet
Milestone
pl:1.2
Development

Successfully merging a pull request may close this issue.

enable testing DDP examples Lightning-AI/pytorch-lightning
3 participants
@awaelchli @Borda @edenlightning