Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doctests for example 2/n segmentation #5083

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 11, 2020

What does this PR do?

Adding doctest for SegModel, follow-up #5079

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added example ci Continuous Integration refactor labels Dec 11, 2020
@Borda Borda added this to the 1.1.x milestone Dec 11, 2020
@Borda Borda changed the title adding doctest for segmentation example add doctests for example 2/n segmentation Dec 11, 2020
@Borda Borda mentioned this pull request Dec 11, 2020
@Borda Borda requested a review from tchaton December 11, 2020 15:13
@Borda Borda changed the title add doctests for example 2/n segmentation add doctests for example 2/n segmentation [wip] Dec 11, 2020
@Borda Borda marked this pull request as ready for review December 20, 2020 10:53
@Borda Borda changed the title add doctests for example 2/n segmentation [wip] add doctests for example 2/n segmentation Dec 20, 2020
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #5083 (499709f) into master (bb6dfb6) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5083   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9932    9932           
======================================
- Hits         9246    9239    -7     
- Misses        686     693    +7     

@Borda Borda added the ready PRs ready to be merged label Dec 20, 2020
@justusschock
Copy link
Member

Sorry @tchaton clicked the wrong button

@Borda Borda merged commit a401fb3 into master Dec 21, 2020
@Borda Borda deleted the tests/doctest-segmodel branch December 21, 2020 11:04
Borda added a commit that referenced this pull request Dec 23, 2020
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
Borda added a commit that referenced this pull request Dec 29, 2020
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
Borda added a commit that referenced this pull request Jan 4, 2021
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
Borda added a commit that referenced this pull request Jan 4, 2021
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
Borda added a commit that referenced this pull request Jan 5, 2021
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration example ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants