Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Deprecate support for the TestTube logger #9037

Closed
ananthsub opened this issue Aug 22, 2021 · 0 comments · Fixed by #9065
Closed

[RFC] Deprecate support for the TestTube logger #9037

ananthsub opened this issue Aug 22, 2021 · 0 comments · Fixed by #9065
Labels
deprecation Includes a deprecation feature Is an improvement or enhancement help wanted Open to be worked on let's do it! approved to implement logger Related to the Loggers refactor

Comments

@ananthsub
Copy link
Contributor

ananthsub commented Aug 22, 2021

Proposed refactoring or deprecation

Motivation

This logger is not actively maintained: https://github.com/williamFalcon/test-tube
This came up during the discussion of API improvements we can make to the Lightning Logger interace: #9004

The TestTube logger is the only logger which supports close - this is likely an artifact from the early days of Lightning. Are there currently users of this logger? @edenafek ?

Side-effect of #7740 and https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit

If the library isn't actively maintained, deprecating & removing this support means:

  • Simplified options for users as to what loggers the framework provides
  • Reduced framework maintenance cost (tests, dependencies)

Pitch

Deprecate support for test tube if it's not actively maintained.

cc @edward-io

Additional context


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

  • Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

  • Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

@ananthsub ananthsub added feature Is an improvement or enhancement help wanted Open to be worked on refactor logger Related to the Loggers deprecation Includes a deprecation labels Aug 22, 2021
@ananthsub ananthsub changed the title RFC: Deprecate support for the TestTube logger [RFC] Deprecate support for the TestTube logger Aug 23, 2021
@tchaton tchaton added the let's do it! approved to implement label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation feature Is an improvement or enhancement help wanted Open to be worked on let's do it! approved to implement logger Related to the Loggers refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants