Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Lightning architecture & API #7740

Closed
carmocca opened this issue May 27, 2021 · 5 comments
Closed

Review Lightning architecture & API #7740

carmocca opened this issue May 27, 2021 · 5 comments
Assignees
@ananthsub
Labels
design Includes a design discussion refactor

Comments

@carmocca
Copy link
Contributor

carmocca commented May 27, 2021 •
edited
Loading

 Document: https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#
@carmocca carmocca added the design Includes a design discussion label May 27, 2021
@carmocca carmocca added this to the v1.4 milestone May 27, 2021
@carmocca carmocca self-assigned this May 27, 2021
@carmocca carmocca mentioned this issue May 27, 2021
Merged
9 tasks
@awaelchli awaelchli mentioned this issue Jun 4, 2021
Closed
This was referenced Jun 11, 2021
Merged
Merged
Merged
Merged
This was referenced Jun 21, 2021
Merged
Merged
Merged
@edenlightning
Copy link
Contributor

@carmocca what is TODO?

@carmocca
Copy link
Contributor Author

carmocca commented Jul 6, 2021

Plan was to write a document with all these things, but many have been covered by @ananthsub 's API review.

Have been using this issue to link all the PR's I've opened testing the hook consistency

@edenlightning edenlightning modified the milestones: v1.4, v1.5 Jul 6, 2021
@carmocca carmocca mentioned this issue Jul 7, 2021
Merged
11 tasks
@ananthsub
Copy link
Contributor

@carmocca do you mind if I hijack this issue for https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit#

The intention is to go through every component in Lightning and do an API review

@ananthsub ananthsub mentioned this issue Jul 8, 2021
Closed
@carmocca
Copy link
Contributor Author

carmocca commented Jul 8, 2021

Go for it!

@ananthsub ananthsub changed the title Review existing hook API Review Lightning architecture & API Jul 19, 2021
This was referenced Jul 19, 2021
Closed
Closed
@ananthsub ananthsub mentioned this issue Jul 28, 2021
Closed
This was referenced Aug 4, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 23, 2021
Closed
Open
@edward-io edward-io mentioned this issue Aug 26, 2021
Closed
@ananthsub ananthsub mentioned this issue Sep 30, 2021
Closed
@carmocca carmocca mentioned this issue Oct 27, 2021
Merged
11 tasks
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 4, 2021
@awaelchli awaelchli mentioned this issue Nov 5, 2021
Merged
11 tasks
@ananthsub ananthsub mentioned this issue Nov 10, 2021
Closed
This was referenced Nov 18, 2021
Merged
Closed
@awaelchli awaelchli mentioned this issue Nov 27, 2021
Closed
This was referenced Dec 2, 2021
Closed
Closed
Closed
@awaelchli awaelchli mentioned this issue Dec 9, 2021
Merged
11 tasks
This was referenced Dec 23, 2021
Closed
Closed
Closed
This was referenced Jan 11, 2022
Closed
Closed
Closed
Closed
@carmocca carmocca modified the milestones: 1.6, None Feb 1, 2022
@carmocca carmocca removed their assignment Feb 3, 2022
@ananthsub ananthsub mentioned this issue Feb 7, 2022
Closed
@carmocca
Copy link
Contributor Author

carmocca commented Apr 6, 2022

@ananthsub Do you still want to keep this open?

@carmocca carmocca removed this from the future milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananthsub ananthsub

Labels
design Includes a design discussion refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ananthsub @awaelchli @carmocca @edenlightning