Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evaluation hook tests #8013

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Update evaluation hook tests #8013

merged 6 commits into from
Jun 18, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

  • Merge tests
  • Test arguments

Related to the Lightning hooks review: #7740

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Jun 17, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 17, 2021
@carmocca carmocca self-assigned this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #8013 (9dd95cc) into master (906de2a) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8013    +/-   ##
=======================================
- Coverage      92%     91%    -0%     
=======================================
  Files         207     210     +3     
  Lines       13389   13576   +187     
=======================================
+ Hits        12259   12411   +152     
- Misses       1130    1165    +35     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the explicit tests we had before more :)

@carmocca
Copy link
Contributor Author

I like the explicit tests we had before more :)

I didn't change it to code-golf it. It has the advantage of easily checking any divergence between validate and test

@carmocca carmocca added the ready PRs ready to be merged label Jun 17, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Definitely great value to validate validate vs test, but the structure seems more convoluted now.

@carmocca carmocca enabled auto-merge (squash) June 18, 2021 11:59
tests/models/test_hooks.py Outdated Show resolved Hide resolved
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
tests/models/test_hooks.py Outdated Show resolved Hide resolved
@carmocca carmocca merged commit e55f01e into master Jun 18, 2021
@carmocca carmocca deleted the tests/update-eval-hook-tests branch June 18, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants