Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fit with val hook test #8060

Merged
merged 27 commits into from
Jun 21, 2021
Merged

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Related to the Lightning hooks review: #7740

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working ci Continuous Integration labels Jun 21, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 21, 2021
@carmocca carmocca self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #8060 (ca3ec93) into master (dd340a6) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8060   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13590   13590           
======================================
- Hits        12463   12425   -38     
- Misses       1127    1165   +38     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca added the ready PRs ready to be merged label Jun 21, 2021
tests/models/test_hooks.py Show resolved Hide resolved
tests/models/test_hooks.py Outdated Show resolved Hide resolved
tests/models/test_hooks.py Show resolved Hide resolved
tests/models/test_hooks.py Show resolved Hide resolved
tests/models/test_hooks.py Outdated Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) June 21, 2021 17:03
@carmocca carmocca merged commit f1fa4c4 into master Jun 21, 2021
@carmocca carmocca deleted the tests/improve-hook-test-full-fit branch June 21, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants