Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality in AcceleratorConnector._configure_slurm_ddp #10102

Merged
merged 23 commits into from
Nov 17, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 24, 2021

What does this PR do?

Follow up to #10101
Part of #7740 #10417 (simplifying accelerator connector) (baby steps)

Simplifies the _configure_slurm_ddp method and improves code quality. Adds a docstring for explanation.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta

@awaelchli awaelchli added this to the v1.5 milestone Oct 24, 2021
@awaelchli awaelchli changed the title Refactor/is slurm managing tasks Improve code quality in AcceleratorConnector._configure_slurm_ddp Oct 24, 2021
Base automatically changed from refactor/is_slurm_managing_tasks_0 to master October 25, 2021 17:52
@awaelchli awaelchli modified the milestones: v1.5, v1.6 Nov 1, 2021
@awaelchli awaelchli marked this pull request as ready for review November 16, 2021 04:15
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice essential clean up!

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 16, 2021 16:25
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #10102 (2e005a8) into master (c15b84d) will increase coverage by 49%.
The diff coverage is 100%.

❗ Current head 2e005a8 differs from pull request most recent head 4129e9e. Consider uploading reports for the commit 4129e9e to get more accurate results

@@            Coverage Diff            @@
##           master   #10102     +/-   ##
=========================================
+ Coverage      43%      92%    +49%     
=========================================
  Files         178      178             
  Lines       16244    16240      -4     
=========================================
+ Hits         6936    14900   +7964     
+ Misses       9308     1340   -7968     

@awaelchli awaelchli merged commit 1ff35ed into master Nov 17, 2021
@awaelchli awaelchli deleted the refactor/is_slurm_managing_tasks branch November 17, 2021 23:10
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants