-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code quality in AcceleratorConnector._configure_slurm_ddp
#10102
Conversation
AcceleratorConnector._configure_slurm_ddp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice essential clean up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10102 +/- ##
=========================================
+ Coverage 43% 92% +49%
=========================================
Files 178 178
Lines 16244 16240 -4
=========================================
+ Hits 6936 14900 +7964
+ Misses 9308 1340 -7968 |
What does this PR do?
Follow up to #10101
Part of #7740 #10417 (simplifying accelerator connector) (baby steps)
Simplifies the
_configure_slurm_ddp
method and improves code quality. Adds a docstring for explanation.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @justusschock @awaelchli @akihironitta