-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LightningDataModule
hook test and fix dataloader_idx
argument
#7941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 11, 2021 12:15
Codecov Report
@@ Coverage Diff @@
## master #7941 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 203 203
Lines 13129 13125 -4
======================================
- Hits 12017 11974 -43
- Misses 1112 1151 +39 |
tchaton
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
awaelchli
approved these changes
Jun 11, 2021
kaushikb11
approved these changes
Jun 13, 2021
carmocca
commented
Jun 13, 2021
justusschock
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
ci
Continuous Integration
data handling
Generic data-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HookedDataModule
to append the called hooks dynamically. Any new hook will make the test fail. We want this so there's no forgetting to update the test.dataloader_idx
argument during predict if there is more than one dataloader. This is consistent with the rest of the loops.Related to the Lightning hooks review: #7740
Before submitting
PR review