Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize fit hook test with different precision plugins #8070

Merged
merged 47 commits into from
Jul 5, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jun 22, 2021

What does this PR do?

The plugins are deepspeed, amp, and apex

Part of #7865
Related to the Lightning hooks review: #7740

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement ci Continuous Integration labels Jun 22, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 22, 2021
@carmocca carmocca self-assigned this Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #8070 (88b3183) into master (7b6d0a8) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8070   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         212     212           
  Lines       13729   13729           
======================================
- Hits        12752   12685   -67     
- Misses        977    1044   +67     

tests/models/test_hooks.py Show resolved Hide resolved
tests/models/test_hooks.py Outdated Show resolved Hide resolved
tests/models/test_hooks.py Outdated Show resolved Hide resolved
@carmocca carmocca mentioned this pull request Jun 22, 2021
11 tasks
@carmocca carmocca force-pushed the tests/parametrize-hooks-precision-plugins branch 2 times, most recently from 618bfe6 to 9c33aac Compare June 22, 2021 14:44
@carmocca carmocca force-pushed the tests/parametrize-hooks-precision-plugins branch 4 times, most recently from cd9fb6f to ae92cb2 Compare June 22, 2021 15:14
@carmocca carmocca force-pushed the tests/parametrize-hooks-precision-plugins branch from ae92cb2 to 39c4a85 Compare June 22, 2021 15:20
@carmocca carmocca marked this pull request as ready for review July 3, 2021 18:25
@mergify mergify bot added the has conflicts label Jul 5, 2021
@mergify mergify bot removed the has conflicts label Jul 5, 2021
@carmocca carmocca enabled auto-merge (squash) July 5, 2021 10:27
@carmocca carmocca added the ready PRs ready to be merged label Jul 5, 2021
@carmocca carmocca merged commit ea88105 into master Jul 5, 2021
@carmocca carmocca deleted the tests/parametrize-hooks-precision-plugins branch July 5, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants