Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize fit hook test with manual optimization #8071

Merged
merged 79 commits into from
Jul 9, 2021
Merged

Parametrize fit hook test with manual optimization #8071

merged 79 commits into from
Jul 9, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Related to the Lightning hooks review: #7740

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #8071 (c1cf8a0) into master (1c825a2) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8071   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         214     214           
  Lines       13900   13900           
======================================
  Hits        12814   12814           
  Misses       1086    1086

tchaton
tchaton approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
@carmocca carmocca marked this pull request as ready for review July 8, 2021 14:04
@carmocca carmocca changed the title [WIP] Parametrize fit hook test with manual optimization Parametrize fit hook test with manual optimization Jul 8, 2021
@carmocca carmocca added this to the v1.4 milestone Jul 8, 2021
@carmocca carmocca added ci Continuous Integration ready PRs ready to be merged labels Jul 8, 2021
Borda
Borda approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, really 74 commits? can you prune the merge message later...

@carmocca
Copy link
Contributor Author

carmocca commented Jul 8, 2021

lgtm, really 74 commits? can you prune the merge message later...

Yeah, I always remove the commit list when merging

@carmocca carmocca enabled auto-merge (squash) July 8, 2021 14:17
@carmocca carmocca added the priority: 0 High priority task label Jul 8, 2021
awaelchli
awaelchli approved these changes Jul 8, 2021
View reviewed changes
tests/models/test_hooks.py Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Jul 9, 2021
tchaton
tchaton approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot removed the has conflicts label Jul 9, 2021
@carmocca carmocca merged commit 0dfc265 into master Jul 9, 2021
@carmocca carmocca deleted the tests/parametrize-hooks-manual-opt branch July 9, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @awaelchli @Borda @tchaton @kaushikb11