Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize fit hook test with manual optimization #8071

Merged
merged 79 commits into from
Jul 9, 2021
Merged

Parametrize fit hook test with manual optimization #8071

merged 79 commits into from
Jul 9, 2021

Commits on Jun 21, 2021

  1. Parametrize fit hook test with different precision plugins

    @carmocca
    carmocca committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    a5f2e6b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Fix tests

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    0ce2295 View commit details
    Browse the repository at this point in the history

  2. Parametrize fit hook test with manual optimization

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c22fc74 View commit details
    Browse the repository at this point in the history

  3. Unnecessary parenthesis

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    4b1534b View commit details
    Browse the repository at this point in the history

  4. WIP

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f5828a8 View commit details
    Browse the repository at this point in the history

  5. Comments

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    72d5ee3 View commit details
    Browse the repository at this point in the history

  6. Fix message

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f34ee7e View commit details
    Browse the repository at this point in the history

  7. Test CI error

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    39c4a85 View commit details
    Browse the repository at this point in the history

  8. Revert "Test CI error" 

    This reverts commit 39c4a85.
    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c3b458d View commit details
    Browse the repository at this point in the history

  9. Add ddp training type teardown

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c700cab View commit details
    Browse the repository at this point in the history

  10. Update CHANGELOG

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e5602c9 View commit details
    Browse the repository at this point in the history

  11. Adrian's fix

    @carmocca
    carmocca committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    52b2256 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Use destructor

    @carmocca
    carmocca committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    0b94b6c View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @carmocca
    carmocca authored Jun 23, 2021
    Configuration menu
    Copy the full SHA
    aaf32ab View commit details
    Browse the repository at this point in the history

  3. RPC destructor

    @carmocca
    carmocca committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    0444d54 View commit details
    Browse the repository at this point in the history

  4. Update pytorch_lightning/plugins/training_type/ddp.py

    @carmocca
    carmocca authored Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5d4f811 View commit details
    Browse the repository at this point in the history

  5. Why do you not work :(

    @carmocca
    carmocca committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    bf8766d View commit details
    Browse the repository at this point in the history

  6. Missing condition

    @carmocca
    carmocca committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    48bcb7e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into bug/teardown-ddp-process-group

    @carmocca
    carmocca committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5d6fa39 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Fix deepspeed test

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    21ad2d8 View commit details
    Browse the repository at this point in the history

  2. GC collect in conftest

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    bbc489e View commit details
    Browse the repository at this point in the history

  3. Do not show warnings for special tests

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    5b06fd2 View commit details
    Browse the repository at this point in the history

  4. Needs to run on 1.8 

    To avoid: "RuntimeError: NCCL error in: /pytorch/torch/lib/c10d/ProcessGroupNCCL.cpp:32, unhandled cuda error, NCCL version 2.4.8"
    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    5e69ed8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into tests/parametrize-hooks-precision-plugins

    @awaelchli
    awaelchli committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    1e0cf40 View commit details
    Browse the repository at this point in the history

  6. Run torch 1.8

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    aed51a2 View commit details
    Browse the repository at this point in the history

  7. Skip test due to 'Python bus error'

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    e0a3e87 View commit details
    Browse the repository at this point in the history

  8. Debug NCCL

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    9ee2d19 View commit details
    Browse the repository at this point in the history

  9. shm size

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    3588aaa View commit details
    Browse the repository at this point in the history

  10. Disable warnings for special tests

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    067bf1a View commit details
    Browse the repository at this point in the history

  11. Remove NCCL_DEBUG statement

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    6060b05 View commit details
    Browse the repository at this point in the history

  12. Try smaller shm size

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    f0fa1b7 View commit details
    Browse the repository at this point in the history

  13. Revert "Skip test due to 'Python bus error'" 

    This reverts commit e0a3e87.
    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    6dd7038 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'ci/gpu-tests-torch-1.8' into bug/teardown-ddp-process-g… 

    …roup
    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    53082bf View commit details
    Browse the repository at this point in the history

  15. README and adjust versions

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    73e62f8 View commit details
    Browse the repository at this point in the history

  16. Avoid self.on_gpu call

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    902ef02 View commit details
    Browse the repository at this point in the history

  17. empty cache cleanup

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4ce0f9a View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into bug/teardown-ddp-process-group

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    990b2e9 View commit details
    Browse the repository at this point in the history

  19. More garbage collection

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    738daa5 View commit details
    Browse the repository at this point in the history

  20. Unroll parametrizations

    @awaelchli @carmocca
    awaelchli authored and carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    236aa97 View commit details
    Browse the repository at this point in the history

  21. Do not reuse mock

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    ffa532d View commit details
    Browse the repository at this point in the history

  22. Merge branch 'master' into tests/parametrize-hooks-precision-plugins

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    5aa3790 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'bug/teardown-ddp-process-group' into tests/parametrize-… 

    …hooks-precision-plugins
    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    78baa5f View commit details
    Browse the repository at this point in the history

  24. Undo changes

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    e190089 View commit details
    Browse the repository at this point in the history

  25. Undo notebooks modification

    @carmocca
    carmocca committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    261a166 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. Merge branch 'master' into tests/parametrize-hooks-precision-plugins

    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    acec7b0 View commit details
    Browse the repository at this point in the history

  2. Undo

    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    33a68d4 View commit details
    Browse the repository at this point in the history

  3. Fix test

    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    ac006c7 View commit details
    Browse the repository at this point in the history

  4. Revert "WIP" 

    This reverts commit f5828a8.
    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    9efe252 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    beecfb9 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'tests/parametrize-hooks-precision-plugins' into tests/p… 

    …arametrize-hooks-manual-opt
    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    01dfc7c View commit details
    Browse the repository at this point in the history

  7. Rename

    @carmocca
    carmocca committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    dc7b17b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    8e1f60e View commit details
    Browse the repository at this point in the history

  2. Remove optimizers

    @carmocca
    carmocca committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    9c3fbd4 View commit details
    Browse the repository at this point in the history

  3. Fix bug with LightningOptimizer

    @carmocca
    carmocca committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    f90348c View commit details
    Browse the repository at this point in the history

  4. Add optimizers

    @carmocca
    carmocca committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    cbf7b36 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Update CHANGELOG

    @carmocca
    carmocca committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    d1a48a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    1869128 View commit details
    Browse the repository at this point in the history

  3. On after backward refactor

    @carmocca
    carmocca committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    fe06ec0 View commit details
    Browse the repository at this point in the history

  4. Do not call super

    @carmocca
    carmocca committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    938de4d View commit details
    Browse the repository at this point in the history

  5. Fixes

    @carmocca
    carmocca committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    20da3b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Remove should_accumulate

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    abfbdd6 View commit details
    Browse the repository at this point in the history

  2. pre/post backward refactor

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    9c8993c View commit details
    Browse the repository at this point in the history

  3. Call the LM backward hook

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    d7d2a71 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    f3c3726 View commit details
    Browse the repository at this point in the history

  5. Remove dev debug patch

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    7cfed58 View commit details
    Browse the repository at this point in the history

  6. Fix test

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    7838eae View commit details
    Browse the repository at this point in the history

  7. Remove optimizer arguments and typing

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    c070e84 View commit details
    Browse the repository at this point in the history

  8. Docs fixes

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    5fabca8 View commit details
    Browse the repository at this point in the history

  9. Fix comment

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    cf89192 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    6d77d72 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    f88cc51 View commit details
    Browse the repository at this point in the history

  12. Undo changes

    @carmocca
    carmocca committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    d749a85 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d1c342b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    816cb4c View commit details
    Browse the repository at this point in the history

  3. Split manual and auto

    @carmocca
    carmocca committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e2ea758 View commit details
    Browse the repository at this point in the history

  4. Undo change

    @carmocca
    carmocca committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    160c2b4 View commit details
    Browse the repository at this point in the history

  5. Deepsource

    @carmocca
    carmocca committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    cbc78db View commit details
    Browse the repository at this point in the history

  6. Remove optimizers

    @carmocca
    carmocca committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6aa229c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Merge branch 'master' into tests/parametrize-hooks-manual-opt

    @carmocca
    carmocca authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    c1cf8a0 View commit details
    Browse the repository at this point in the history