Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fit with no validation hook test #7738

Merged
merged 24 commits into from
Jun 23, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 27, 2021

What does this PR do?

Related to the Lightning hooks review: #7740

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label May 27, 2021
@carmocca carmocca added this to the v1.4 milestone May 27, 2021
@carmocca carmocca self-assigned this May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #7738 (ef60416) into master (f1fa4c4) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7738   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13590   13590           
======================================
- Hits        12463   12425   -38     
- Misses       1127    1165   +38     

@carmocca carmocca marked this pull request as draft May 28, 2021 15:15
@carmocca carmocca mentioned this pull request Jun 9, 2021
11 tasks
@carmocca carmocca changed the title Add callback to hook tests and add predict test [WIP] Add callback to hook tests and add predict test Jun 11, 2021
@carmocca carmocca changed the title [WIP] Add callback to hook tests and add predict test [WIP] Add callback to hook tests Jun 14, 2021
@carmocca carmocca mentioned this pull request Jun 16, 2021
10 tasks
@carmocca carmocca changed the title [WIP] Add callback to hook tests Update fit with no validation hook test Jun 21, 2021
@carmocca carmocca added feature Is an improvement or enhancement ready PRs ready to be merged labels Jun 21, 2021
@carmocca carmocca marked this pull request as ready for review June 21, 2021 17:53
@Borda Borda merged commit 54ac4e0 into master Jun 23, 2021
@Borda Borda deleted the tests/improve-hook-tests branch June 23, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants