-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fit with no validation hook test #7738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
May 27, 2021 14:28
Codecov Report
@@ Coverage Diff @@
## master #7738 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 210 210
Lines 13590 13590
======================================
- Hits 12463 12425 -38
- Misses 1127 1165 +38 |
justusschock
approved these changes
May 27, 2021
awaelchli
reviewed
May 27, 2021
carmocca
force-pushed
the
tests/improve-hook-tests
branch
from
May 28, 2021 15:14
af8330a
to
1de5fbd
Compare
11 tasks
carmocca
changed the title
Add callback to hook tests and add predict test
[WIP] Add callback to hook tests and add predict test
Jun 11, 2021
carmocca
changed the title
[WIP] Add callback to hook tests and add predict test
[WIP] Add callback to hook tests
Jun 14, 2021
carmocca
changed the title
[WIP] Add callback to hook tests
Update fit with no validation hook test
Jun 21, 2021
carmocca
added
feature
Is an improvement or enhancement
ready
PRs ready to be merged
labels
Jun 21, 2021
awaelchli
reviewed
Jun 22, 2021
awaelchli
approved these changes
Jun 22, 2021
Borda
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to the Lightning hooks review: #7740
Before submitting
PR review