-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract dataloader utilities from TrainerDataLoadingMixin
#10145
Conversation
for more information, see https://pre-commit.ci
…s' into refactor/extract-dataloader-utils
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10145 +/- ##
========================================
Coverage 92% 92%
========================================
Files 178 178
Lines 16286 16400 +114
========================================
+ Hits 14941 15057 +116
+ Misses 1345 1343 -2 |
What does this PR do?
Addresses the suggestion by @ananthsub to move some static methods of the
TrainerDataLoadingMixin
to utilities:#9987 (comment)
TrainerDataLoadingMixin
which we eventually want to remove anyway (Review Lightning architecture & API #7740)TrainerDataLoadingMixin
Does your PR introduce any breaking changes? If yes, please list them.
No, because the methods were marked as "protected" (in reality they really are not, as we use them publicly. The "_" prefix is to discourage their use)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @justusschock @awaelchli @akihironitta @tchaton @Borda