Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement double optimizer closure for hook structure consistency #10167

Merged
merged 8 commits into from
Oct 29, 2021
Merged

Implement double optimizer closure for hook structure consistency #10167

merged 8 commits into from
Oct 29, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 27, 2021 •
edited
Loading

What does this PR do?

Part of #7740

Since we advertise on_before_optimizer_step as a good place to inspect (unscaled) gradients, this is a bug-fix because backward will not have been run yet (hence no gradients) when PrecisionPlugin or TPUPrecisionPlugin are used.

Does your PR introduce any breaking changes? If yes, please list them.

The hook order was changed.

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.6 milestone Oct 27, 2021
@carmocca carmocca self-assigned this Oct 27, 2021
Base automatically changed from bugfix/track-grad-norm to master October 28, 2021 15:23
@carmocca carmocca added the bug Something isn't working label Oct 29, 2021
@carmocca carmocca modified the milestones: v1.6, v1.5 Oct 29, 2021
@carmocca carmocca marked this pull request as ready for review October 29, 2021 00:59
awaelchli
awaelchli approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool that this now works!

pytorch_lightning/plugins/precision/precision_plugin.py Outdated Show resolved Hide resolved
tchaton
tchaton approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/plugins/precision/precision_plugin.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/precision_plugin.py Outdated Show resolved Hide resolved
tests/models/test_hooks.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@carmocca carmocca enabled auto-merge (squash) October 29, 2021 13:02
@carmocca carmocca merged commit 81d15c5 into master Oct 29, 2021
@carmocca carmocca deleted the feat/double-closure branch October 29, 2021 13:03
@carmocca carmocca mentioned this pull request Oct 29, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @tchaton @rohitgr7