Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for datamodule hparams #9102

Closed
s-rog opened this issue Aug 25, 2021 · 1 comment · Fixed by #9253 or #9428
Closed

Add docs for datamodule hparams #9102

s-rog opened this issue Aug 25, 2021 · 1 comment · Fixed by #9253 or #9428
Labels
docs Documentation related good first issue Good for newcomers help wanted Open to be worked on let's do it! approved to implement

Comments

@s-rog
Copy link
Contributor

s-rog commented Aug 25, 2021 •
edited
Loading

📚 Documentation

Add missing docs for #3792

(Possibly depends on #8948 if there are changes)
@s-rog s-rog added help wanted Open to be worked on docs Documentation related labels Aug 25, 2021
@awaelchli awaelchli added the let's do it! approved to implement label Aug 25, 2021
@s-rog s-rog added the good first issue Good for newcomers label Aug 31, 2021
@popfido popfido mentioned this issue Sep 1, 2021
Merged
12 tasks
@s-rog
Copy link
Contributor Author

s-rog commented Sep 8, 2021

I was thinking more about the datamodule page which currently doesn't mention hparams at all.
https://pytorch-lightning.readthedocs.io/en/stable/extensions/datamodules.html
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/docs/source/extensions/datamodules.rst

@s-rog s-rog reopened this Sep 8, 2021
@s-rog s-rog mentioned this issue Sep 10, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation related good first issue Good for newcomers help wanted Open to be worked on let's do it! approved to implement
Projects
None yet
Milestone
No milestone
2 participants
@awaelchli @s-rog