Hyperparameters for datamodule #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 2, 2020 11:23
We want to use the hyperparameter saving code in the datamodule, too.
A DataModule can now save its hyperparameters just like a LightningModule.
The function takes a dict or namespace and adds the contained hparams to the existing ones. If a hparam already exists, an error is thrown to avoid overwriting it.
To log and checkpoint the hparams of the DataModule together with the model, we add them to the model's hparams before training.
|
This pull request is now in conflict... :( |
|
Hello @tilman151! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-09 14:38:05 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3792 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 215 216 +1
Lines 13988 14009 +21
=======================================
- Hits 12965 12329 -636
- Misses 1023 1680 +657 |
|
This pull request is now in conflict... :( |
added 9 commits
October 22, 2020 10:16
# Conflicts: # pytorch_lightning/core/lightning.py # tests/core/test_datamodules.py # tests/models/test_hparams.py
The function for adding hparams is now only available in lightning module. The error message is now specific enough without reraising it in the training loop.
tilman151
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw and
SeanNaren
as code owners
carmocca
reviewed
Jul 8, 2021
ananthsub
reviewed
Jul 8, 2021
ananthsub
reviewed
Jul 8, 2021
awaelchli
reviewed
Jul 9, 2021
awaelchli
approved these changes
Jul 9, 2021
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
tchaton
approved these changes
Jul 9, 2021
|
Should this be documented in the datamodule docs? |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3769
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃