Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the passed dtype with self.log #10076

Merged
merged 8 commits into from
Nov 19, 2021
Merged

Respect the passed dtype with self.log #10076

merged 8 commits into from
Nov 19, 2021

Conversation

qqueing
Copy link
Contributor

@qqueing qqueing commented Oct 22, 2021 •
edited by carmocca
Loading

What does this PR do?

Author: @carmocca

Fixes #9713
Fixes #8930

Does your PR introduce any breaking changes? If yes, please list them.

Batch size must be fixed point. This would only be breaking if somebody was importing and using ResultMetrics directly (please don't)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@tchaton tchaton added this to the v1.6.x milestone Nov 1, 2021
@awaelchli awaelchli modified the milestones: v1.6.x, 1.5.x Nov 3, 2021
@tchaton
Copy link
Contributor

tchaton commented Nov 18, 2021

@carmocca Any updates on this PR ?

@qqueing @carmocca
bug fix for logging
99c2316 
value
Out[35]: tensor(3211., device='cuda:0')
value.mean() * batch_size  / batch_size
Out[36]: tensor(3210.9998, device='cuda:0')
value.type(torch.float64).mean() * batch_size / batch_size
Out[37]: tensor(3211., device='cuda:0', dtype=torch.float64)
@carmocca carmocca self-assigned this Nov 19, 2021
@carmocca carmocca changed the title bug fix for logging Respect the passed dtype with self.log Nov 19, 2021
@mergify mergify bot removed the has conflicts label Nov 19, 2021
@carmocca carmocca added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Nov 19, 2021
carmocca
carmocca approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton I finished it.

@carmocca carmocca added logging Related to the `LoggerConnector` and `log()` and removed logging Related to the `LoggerConnector` and `log()` labels Nov 19, 2021
rohitgr7
rohitgr7 approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

pytorch_lightning/trainer/connectors/logger_connector/result.py Outdated Show resolved Hide resolved
tests/core/test_metric_result_integration.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 19, 2021
tchaton
tchaton approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Great work !

pytorch_lightning/trainer/connectors/logger_connector/result.py Outdated Show resolved Hide resolved
@carmocca @rohitgr7
Apply suggestions from code review
4ba6537 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@carmocca carmocca enabled auto-merge (squash) November 19, 2021 14:41
@carmocca carmocca merged commit e83e8ae into Lightning-AI:master Nov 19, 2021
rohitgr7 added a commit that referenced this pull request Nov 20, 2021
@qqueing @carmocca @rohitgr7
Respect the passed dtype with self.log (#10076)
7282ed4 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@qqueing @carmocca
@rohitgr7 @Raalsky
Respect the passed dtype with self.log (Lightning-AI#10076)
8b62f86 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
@qqueing @carmocca
@rohitgr7 @awaelchli
Respect the passed dtype with self.log (#10076)
a7b6206 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@qqueing @carmocca
@rohitgr7 @lexierule
Respect the passed dtype with self.log (#10076)
2bb4343 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
@awaelchli awaelchli mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

logging precision issue Strange visualization of the log during the test
5 participants
@qqueing @tchaton @carmocca @rohitgr7 @awaelchli