Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mnist examples with lite #10131

Merged
merged 22 commits into from
Oct 26, 2021
Merged

Add Mnist examples with lite #10131

merged 22 commits into from
Oct 26, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 25, 2021

What does this PR do?

This PR adds MNIST example written with pytorch, lite and Lightning.

Does your PR introduce any breaking changes? If yes, please list them.

Nope

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton changed the base branch from master to lite-poc October 25, 2021 17:51
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton self-assigned this Oct 25, 2021
@tchaton tchaton added this to the v1.5 milestone Oct 25, 2021
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while the example itself is great, this adds much disorganization to the pl_examples folder as now the basic_examples folder has no meaning and the lite examples are in two different folders.

pl_examples/mnist_examples/lightning.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/lightning.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/lite.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/lite.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/lite.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/lite.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/lite.py Outdated Show resolved Hide resolved
pl_examples/mnist_examples/pytorch.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2021
@tchaton tchaton requested a review from rohitgr7 October 26, 2021 12:05
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments.. overall looks good 🚀

@tchaton tchaton merged commit d566082 into lite-poc Oct 26, 2021
@tchaton tchaton deleted the lite_mnist branch October 26, 2021 17:23
@tchaton tchaton restored the lite_mnist branch October 26, 2021 17:28
@carmocca carmocca deleted the lite_mnist branch October 26, 2021 22:24
@tchaton tchaton mentioned this pull request Oct 27, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants