-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mnist examples with lite #10131
Add Mnist examples with lite #10131
Conversation
for more information, see https://pre-commit.ci
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while the example itself is great, this adds much disorganization to the pl_examples folder as now the basic_examples folder has no meaning and the lite examples are in two different folders.
pl_examples/basic_examples/mnist_examples/image_classifier_2_lite.py
Outdated
Show resolved
Hide resolved
pl_examples/basic_examples/mnist_examples/image_classifier_2_lite.py
Outdated
Show resolved
Hide resolved
pl_examples/basic_examples/mnist_examples/image_classifier_3_lite_to_lightning.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments.. overall looks good 🚀
What does this PR do?
This PR adds MNIST example written with pytorch, lite and Lightning.
Does your PR introduce any breaking changes? If yes, please list them.
Nope
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃