Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python testing #10269

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Update Python testing #10269

merged 5 commits into from
Nov 4, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

  • Test Python 3.6 only for the oldest requirement setup
  • Update some Python versions

Part of #9981

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Oct 30, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 30, 2021
@carmocca carmocca self-assigned this Oct 30, 2021
@tchaton tchaton modified the milestones: v1.5, v1.6.x Nov 1, 2021
@awaelchli awaelchli modified the milestones: v1.6.x, 1.5.x Nov 3, 2021
tchaton
tchaton approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2021
@mergify mergify bot requested a review from a team November 4, 2021 10:21
@carmocca carmocca enabled auto-merge (squash) November 4, 2021 17:17
@carmocca carmocca merged commit 939a861 into master Nov 4, 2021
@carmocca carmocca deleted the ci/upgrade-python branch November 4, 2021 17:26
carmocca added a commit that referenced this pull request Nov 5, 2021
@carmocca
Update Python testing (#10269)
37e339a
awaelchli pushed a commit that referenced this pull request Nov 9, 2021
@carmocca @awaelchli
Update Python testing (#10269)
4f6dcb9
lexierule pushed a commit that referenced this pull request Nov 9, 2021
@carmocca @lexierule
Update Python testing (#10269)
71380a5
@akihironitta akihironitta mentioned this pull request Nov 21, 2021
Closed
1 task
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@carmocca @Raalsky
Update Python testing (Lightning-AI#10269)
f409018
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

Assignees

@carmocca carmocca

Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @awaelchli @Borda @tchaton @justusschock