Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apply_to_collection(defaultdict) #10316

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 2, 2021

What does this PR do?

Fixes #10308

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Nov 2, 2021
@carmocca carmocca added this to the v1.6.x milestone Nov 2, 2021
@carmocca carmocca self-assigned this Nov 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) November 2, 2021 21:53
@carmocca carmocca added the priority: 0 High priority task label Nov 2, 2021
@carmocca carmocca mentioned this pull request Nov 3, 2021
12 tasks
@awaelchli awaelchli modified the milestones: v1.6.x, 1.5.x Nov 3, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 3, 2021
@carmocca carmocca merged commit 93caa7c into master Nov 3, 2021
@carmocca carmocca deleted the bugfix/apply-to-collection-defaultdict branch November 3, 2021 11:18
carmocca added a commit that referenced this pull request Nov 3, 2021
carmocca added a commit that referenced this pull request Nov 3, 2021
Copy link

@jshin49 jshin49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making such a quick fix. Looks good to me :)

awaelchli pushed a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
5 participants